Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FroniusSmartmeter Repository #31

Merged
merged 1 commit into from
Nov 28, 2022
Merged

FroniusSmartmeter Repository #31

merged 1 commit into from
Nov 28, 2022

Conversation

SirUli
Copy link
Contributor

@SirUli SirUli commented Nov 28, 2022

The FroniusSmartmeter Repository aims at running a service that collects the data from Fronius Smartmeters to inject it into the venus dbus. The Repository is fully SetupHelper compatible.

@kwindrem kwindrem merged commit 7cea410 into kwindrem:main Nov 28, 2022
@kwindrem
Copy link
Owner

This change will be made the next time the package is updated. There are no changes pending at this time so it may be a while.

You can also add the package manually under Inactive Packages using "new" and filling in the name user and branch

@kwindrem
Copy link
Owner

I don't recommend using "main" for branch as any changes there will be picked up for updates. It's better to create a release tag like I'm doing ("latest"). A better tag would be "released" but I started using "latest" before I thought about having beta releases.

@SirUli
Copy link
Contributor Author

SirUli commented Nov 28, 2022

For the time being i actually added the package under the inactive packages.

In regards to the main branch: I usually only merge once i'm sure it works (working on feature branches due to that reason) but i see your point. I might change that behaviour some time soon.

Thanks for the quick merge! Would you also consider accepting a PR that moves your Readme into Markdown format for better readability?

@SirUli SirUli deleted the feature-fronius branch November 28, 2022 20:57
@kwindrem
Copy link
Owner

I know nothing about markdown (.md) files. If the ReadMe gets moved to markdown format what can I use to edit it? I do all my development under Mac OS.

@SirUli
Copy link
Contributor Author

SirUli commented Nov 28, 2022

You would simply use a text editor. As an example see my README.md which is in RAW just a text with additional formatting. My offer would be that i move your Readme of this repo into Markdown - you take a look and then decide?

@kwindrem
Copy link
Owner

Yes, I like that and formatting seems simple enough with a text editor. Go ahead and make the changes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants